WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/

Home

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers t

from [Jan Beulich]

[Permanent Link][Original]

To:	"Tim Deegan" <Tim.Deegan@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records
From:	"Jan Beulich" <JBeulich@xxxxxxxxxx>
Date:	Fri, 09 Jul 2010 17:02:16 +0100
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Fri, 09 Jul 2010 09:02:59 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<20100709150741.GF31695@xxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<patchbomb.1278682223@xxxxxxxxxxxxxxxxxxxxxxxx> <ed89d064acc184b0c10a.1278682225@xxxxxxxxxxxxxxxxxxxxxxxx> <4C3751E4020000780000A81E@xxxxxxxxxxxxxxxxxx> <20100709150741.GF31695@xxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

>>> On 09.07.10 at 17:07, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
> At 15:44 +0100 on 09 Jul (1278690260), Jan Beulich wrote:
>> >>> On 09.07.10 at 15:30, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
>> >+        if ( tr.extra_bytes > 28 || tr.event >= 0x1000 )
>> 
>> Couldn't you use TRACE_EXTRA_MAX * sizeof(u32) instead of the
>> literal 28?
> 
> Indeed I should.
> 
>> The literal 0x1000 also doesn't look nice - I'm no sure though
>> whether this really is (1 << TRC_SUBCLS_SHIFT).
> 
> Yes it is (the guest's not allowed to define the class or subclass of
> the trace entry).  How about the attached patch instead?

Great, thanks!

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH 0 of 2] New HVMOPs for PV-on-HVM drivers, Tim Deegan [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records, Tim Deegan Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records, Jan Beulich Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records, Tim Deegan Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records, Jan Beulich <= [Xen-devel] [PATCH 1 of 2] Add a new HVMOP which allows an HVM guest to get the current, Tim Deegan

Previous by Date:	Re: [Xen-devel] Runaway real/sys time in newer paravirt domUs?, Jan Beulich
Next by Date:	[Xen-devel] RE: [PATCH] Make frontend features distinct from netback feature flags., Paul Durrant
Previous by Thread:	Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records, Tim Deegan
Next by Thread:	[Xen-devel] [PATCH 1 of 2] Add a new HVMOP which allows an HVM guest to get the current, Tim Deegan
Indexes:	[Date] [Thread] [Top] [All Lists]

This site is hosted by Citrix