WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers t

from [Jan Beulich] [Permanent Link][Original]
To: "Tim Deegan" <Tim.Deegan@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Fri, 09 Jul 2010 15:44:20 +0100
Cc:
Delivery-date: Fri, 09 Jul 2010 07:47:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <ed89d064acc184b0c10a.1278682225@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1278682223@xxxxxxxxxxxxxxxxxxxxxxxx> <ed89d064acc184b0c10a.1278682225@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
>>> On 09.07.10 at 15:30, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
>+        if ( tr.extra_bytes > 28 || tr.event >= 0x1000 )

Couldn't you use TRACE_EXTRA_MAX * sizeof(u32) instead of the
literal 28?

The literal 0x1000 also doesn't look nice - I'm no sure though
whether this really is (1 << TRC_SUBCLS_SHIFT).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [Xen-API] RE: [Xen-devel] XCP Community Call #2 / confcall audio problems, Ian Pratt
Next by Date:  Re: [Xen-devel] [PATCH 0/3] libxl stubdom API cleanup, Tim Deegan
Previous by Thread:  [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records, Tim Deegan
Next by Thread:  Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records, Tim Deegan
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy