Re: [Xen-devel] [PATCH] add xl init scripts

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 4 Jun 2010, Ian Campbell wrote:
> On Fri, 2010-06-04 at 12:37 +0100, Stefano Stabellini wrote:
> > The network script and the vif script to be used with xl can be
> > specified in /etc/sysconfig/xenlightdaemons.
> 
> Would it be better to create /etc/init.d/{xenstored,xenconsoled}
> and /etc/sysconfig/{xenstored,xenconsoled} and have those used
> consistently no matter which toolstack was in use?

There are several small daemons on a xen installation and the number of
them is growing quickly.
Having a separate init script for each of them might not be a winning
strategy in the medium/long term.


> Or maybe a single
> xendaemons script+config would do. In either case /etc/init.d/xend could
> be run only on systems which want xend, similarly for /etc/init.d/xl (if
> such a thing is still necessary after my comments below).
> 

This is exactly the idea, the variable in xen_toolstack is only to make
sure that we don't break anything if both toolstacks and scripts are
installed.


> Is a network script really required for xl? I think it would be more in
> keeping with how xl works to require that the distro configuration be
> setup correctly to create bridges etc e.g. correctly
> setup /etc/network/interfaces under Debian
> or /etc/sysconfig/network-scripts/ifcfg-* under RH derived distros etc.
> 
> Similarly I think xl should assume that the platform has been correctly
> configured with a vif hotplug script with the correct behaviour? It's
> not clear to me why tools/hotplug/Linux/xen-backend.rules needs to use a
> different scheme for vif devices to all the other backend types. The
> script there could be a symlink to one of several variants if necessary,
> there's no reason for it to be a config item in xl (or xend for that
> matter)
> 
> It seems like we are now replicating some of the worst bits of xend
> poking around behind the back of the distro config files in xl.
> 

I think using the distro settings is definitely better, in fact you can
set whatever network script you want (including nothing), in the
NETWORK_SCRIPT variable, maybe NETWORK_SCRIPT= could be the default.

However network-bridge is quite handy and simple to use, I think we
should provide the users a simple way to automatically setup the network
no matter what their distro is.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel