WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [RFC] Physical hot-add cpus and TSC

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "Xen-Devel (xen-devel@xxxxxxxxxxxxxxxxxxx)" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [RFC] Physical hot-add cpus and TSC
From: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
Date: Wed, 26 May 2010 10:39:40 -0700 (PDT)
Cc:
Delivery-date: Wed, 26 May 2010 10:40:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C8231914.15F11%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <5738eada-ede6-4a58-af6b-a7f965aa3ecf@default C8231914.15F11%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
> Subject: Re: [Xen-devel] [RFC] Physical hot-add cpus and TSC
> 
> On 26/05/2010 17:44, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx>
> wrote:
> 
> >> True at the moment, but can we not just whack the TSC of the newly
> >> added CPU  on the head when it is brought online, to match the
> >> boot CPU?
> >
> > Possibly... but the code for whacking the TSC of a CPU after
> > C3-state results in a TSC value that is poorly-aligned with other
> > running TSCs.  If there is a better way for "whacking" that
> > results in a nearly-perfectly-aligned TSC (that would pass
> > a "tsc warp test"), that is an option.
> 
> But what we do in 4.0 is whack all the TSCs at boot time... How is this
> any different?

I don't think we do that anymore, at least not when the
underlying machine is deemed to have a stable TSC
(Invariant TSC or constant/nonstop TSC with max_cstate<3).

> From: Ian Pratt [mailto:Ian.Pratt@xxxxxxxxxxxxx]
> Subject: RE: [Xen-devel] [RFC] Physical hot-add cpus and TSC
> 
> > Possibly... but the code for whacking the TSC of a CPU after
> > C3-state results in a TSC value that is poorly-aligned with other
> > running TSCs.  If there is a better way for "whacking" that
> > results in a nearly-perfectly-aligned TSC (that would pass
> > a "tsc warp test"), that is an option.
> 
> It ought to be possible to enhance the "whacking" code to set the TSC
> based on the topologically nearest live CPU and then sanity-check
> against all others, repeating a few times to protect against SMIs etc.

Well obviously firmware can do it pre-boot, but I don't know
what the impact of the mechanism is on running cpu's.  I'd assume
that at least all guest activity would have to be stopped for
some not-so-short period (~10-100msec?)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel