WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] support cpupool for xl create

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] support cpupool for xl create
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Mon, 10 May 2010 13:07:40 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 10 May 2010 13:09:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BE7AE9F.2090900@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BE3CBCA.7080104@xxxxxxxxxxxxxx> <4BE48CC7.3050101@xxxxxxxx> <4BE7A22C.8020100@xxxxxxxxxxxxxx> <4BE7AAF2.50906@xxxxxxxx> <4BE7AE9F.2090900@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4
On 05/09/2010 11:58 PM, Juergen Gross wrote:
> On 05/10/2010 08:42 AM, Jeremy Fitzhardinge wrote:
>> On 05/09/2010 11:05 PM, Juergen Gross wrote:
>>>> diff -r bbf009817ffb tools/libxl/libxl.c
>>>> --- a/tools/libxl/libxl.c    Fri May 07 19:22:28 2010 +0100
>>>> +++ b/tools/libxl/libxl.c    Fri May 07 14:57:00 2010 -0700
>>>> @@ -169,7 +169,8 @@
>>>>
>>>>        xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/uuid", vm_path),
>>>> uuid_string, strlen(uuid_string));
>>>>        xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/name", vm_path),
>>>> info->name, strlen(info->name));
>>>> -    xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name",
>>>> vm_path), info->poolname, strlen(info->poolname));
>>>> +    if (info->poolname)
>>>> +        xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name",
>>>> vm_path), info->poolname, strlen(info->poolname));
>>>>
>>>>        libxl_xs_writev(ctx, t, dom_path, info->xsdata);
>>>>        libxl_xs_writev(ctx, t, libxl_sprintf(ctx, "%s/platform",
>>>> dom_path), info->platformdata);
>>>>
>>>> fixes it for me.
>>>
>>>
>>> You seem to have specified a not existing cpupool.
>>> The solution should not be to ignore this, but to do a proper test
>>> on the
>>> pool parameter.
>>> Attached patch does this.
>>
>> I'm not using cpupools.  My config makes no mention of "pool" at all.
>
> Strange.
> I tested this case and it worked for me.

Perhaps one thing that you're not testing: I'm using oxenstored, and I'm
xl without ever having started xend, so xenstore starts out completely
empty.  I don't know if that makes a difference.

> Are you sure you have all actual patches installed?

Yes.  I'm seeing this with version bbf009817ffb.

> Could you try "xl create -d" and look for the cpupool settings?

sh-4.0# xl create -dc /etc/xen/f13pv64 
Parsing config file /etc/xen/f13pv64
*** domain_create_info ***
hvm: 0
hap: 0
oos: 1
ssidref: 0
name: f13pv64
uuid: 31878242-49a2-8dce-589c-0ec5a1f297a6
cpupool: (null) (0)
xsdata: (null)
platformdata: (null)



*** domain_build_info ***
timer_mode: -1
hpet: 1
vpt_align: -1
max_vcpus: 1
tsc_mode: 0
max_memkb: 524288
target_memkb: 524288
kernel: /usr/lib/xen/boot/pv-grub-x86_64.gz
hvm: 0
cmdline: (null)
ramdisk: (null)



*** disks_info: 0 ***
backend_domid 0
domid 0
physpath /dev/vg_lilith-raid/xen-f13-64
phystype 4
virtpath xvda
unpluggable 1
readwrite 1
is_cdrom 0



*** vfbs_info: 0 ***
backend_domid 0
domid 0
devid 0
vnc: 1
vnclisten: 0.0.0.0
vncdisplay: 0
vncunused: 1
keymap: (null)
sdl: 0
opengl: 0
display: (null)
xauthority: (null)
Segmentation fault

        J


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel