WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel][PATCH] VMX: Add debug-key 'D' to dump EPT p2m table

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel][PATCH] VMX: Add debug-key 'D' to dump EPT p2m table
From: "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>
Date: Thu, 22 Apr 2010 17:24:05 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 22 Apr 2010 02:27:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100422090020.GA4164@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BD0066A020000780005CBBF@xxxxxxxxxxxxxxxxxx> <20100422090020.GA4164@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acrh+kT9/UVE1lUVSpSYO0NpMWVMFAAAohfA
Thread-topic: [Xen-devel][PATCH] VMX: Add debug-key 'D' to dump EPT p2m table
Hi Tim and Jan,

I modified the patch according to your comments.
Please help to review.

Thanks,
Dongxiao

Tim Deegan wrote:
> At 08:18 +0100 on 22 Apr (1271924329), Jan Beulich wrote:
>>>>> "Xu, Dongxiao"  04/22/10 4:42 AM >>>
>> The use of map_domain_page() here is lacking a respective
>> unmap_domain_page() on all possible paths.
>> 
>> Further, assuming the amount of information printed may be
>> huge, there ought to be calls to process_pending_softirqs()
>> to keep time management from getting screwed.
> 
> Also, for the same reason, I think maybe it shouldn't be marked as a
> 'diagnostic' keyhandler (even though it really is diagnostic, it can
> very easily fill the dmesg buffers).
> 
> Cheers,
> 
> Tim.

Attachment: dump_ept_p2m_table.patch
Description: dump_ept_p2m_table.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel