| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
RE: [Xen-devel][PATCH] VMX: Add debug-key 'D' to dump EPT p2m table
Hi Tim and Jan,
I modified the patch according to your comments.
Please help to review.
Thanks,
Dongxiao
Tim Deegan wrote:
> At 08:18 +0100 on 22 Apr (1271924329), Jan Beulich wrote:
>>>>> "Xu, Dongxiao" 04/22/10 4:42 AM >>>
>> The use of map_domain_page() here is lacking a respective
>> unmap_domain_page() on all possible paths.
>>
>> Further, assuming the amount of information printed may be
>> huge, there ought to be calls to process_pending_softirqs()
>> to keep time management from getting screwed.
>
> Also, for the same reason, I think maybe it shouldn't be marked as a
> 'diagnostic' keyhandler (even though it really is diagnostic, it can
> very easily fill the dmesg buffers).
>
> Cheers,
>
> Tim.
dump_ept_p2m_table.patch
Description: dump_ept_p2m_table.patch
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home