WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel][PATCH] VMX: Add debug-key 'D' to dump EPT p2m table

To: <dongxiao.xu@xxxxxxxxx>,<xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel][PATCH] VMX: Add debug-key 'D' to dump EPT p2m table
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 22 Apr 2010 08:18:49 +0100
Cc:
Delivery-date: Thu, 22 Apr 2010 00:19:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> "Xu, Dongxiao"  04/22/10 4:42 AM >>>
The use of map_domain_page() here is lacking a respective
unmap_domain_page() on all possible paths.

Further, assuming the amount of information printed may be
huge, there ought to be calls to process_pending_softirqs()
to keep time management from getting screwed.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel