WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCHv2 1/4] libxl: extend physinfo structure

To: Andre Przywara <andre.przywara@xxxxxxx>
Subject: [Xen-devel] Re: [PATCHv2 1/4] libxl: extend physinfo structure
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Thu, 22 Apr 2010 10:03:18 +0200
Cc: vincent.hanquez@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian.Jackson@xxxxxxxxxxxxx, Keir.Fraser@xxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 22 Apr 2010 01:04:41 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=lLz9iBWTrTqzledy/Chn2NzDECOAh8W3DBKFmSe4Of8=; b=QK7FVU9Gb+aZwAZ++9aMYioIq5/+vRiRfB+FjPttumUH4nvzpsFFZV5bAHrZB9AEe1 3wtI9drVrgQ/ll5NcpNoZ/rXnzLVIVVsEWha88bp2GHD/FpW95Y0pY+/OQT2hRa3AlKL XGzbrF3Hx4y1nF1rAOfbOjgUGASdRYdNjyBHE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=MRfEaOSCGMm0O4Bo1dxtszmUOdc03YIOolf3p5ePqKrpJ7GfdccGVlQa4QohCynJ2g Pl4qB66ZHh3vO7tsaFoEk/YroU0dBt4dqfv5AtotuJfmi6kFMpJVdmM0KXYi2hfLryIv 7bBdSh05Rbbwyo4q7xGdO770zTLBtj1jNjzYU=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1271859446-25892-2-git-send-email-andre.przywara@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1271859446-25892-1-git-send-email-andre.przywara@xxxxxxx> <1271859446-25892-2-git-send-email-andre.przywara@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3
On 04/21/2010 04:17 PM, Andre Przywara wrote:
The libxl version of the physinfo sysctl does not contain some
fields like nr_nodes or capabilities needed for xl info output.
Add them to the structure and the retrieving function.

Vincent, Stefano, is it okay to break the ABI?

If so, I suggest adding an initial member to be filled with sizeof() of the structure, similar to many Win32 APIs like GetVersionEx.

http://msdn.microsoft.com/en-us/library/ms724451%28VS.85%29.aspx
http://msdn.microsoft.com/en-us/library/ms724834%28VS.85%29.aspx
http://msdn.microsoft.com/en-us/library/ms724833%28VS.85%29.aspx

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel