WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCHv2 0/4] Add "xl info" command

To: Andre Przywara <andre.przywara@xxxxxxx>
Subject: [Xen-devel] Re: [PATCHv2 0/4] Add "xl info" command
From: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>
Date: Wed, 21 Apr 2010 15:56:58 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 21 Apr 2010 07:58:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1271859446-25892-1-git-send-email-andre.przywara@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1271859446-25892-1-git-send-email-andre.przywara@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100411 Icedove/3.0.4
On 21/04/10 15:17, Andre Przywara wrote:
The "info" subcommand is missing from the xl tool.
The attached patchset adds support for this, extending libxl on the way
to provide the necessary info only by using own functions.
On my system the output of xm info and xl info was identical, I omitted
the recent NUMA additions from xl info for now and will provide the
necessary patches later.

Reworked version due to comments from Ian and Vincent (thanks for the review!)
Changes to version 1:
- use Xen public headers for constants instead of (re-)defining them
- comment the meaning of the return value of get_sched_id()
- remove the masking feature for get_version_info
- make the version_info structure a member of libxl_ctx and fill it
   on demand, omitting the need to free it manually

all patches:

Acked-by: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>

Thanks for your contribution !

--
Vincent

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel