WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] continue_hypercall_on_cpu rework using tasklets

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] continue_hypercall_on_cpu rework using tasklets
From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date: Wed, 14 Apr 2010 09:25:25 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 14 Apr 2010 00:26:09 -0700
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1271229928; x=1302765928; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4BC56DE5.6040405@xxxxxxxxxxxxxx>|Date:=20 Wed,=2014=20Apr=202010=2009:25:25=20+0200|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>|MIME-Version: =201.0|To:=20Keir=20Fraser=20<keir.fraser@xxxxxxxxxxxxx> |CC:=20"xen-devel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@lists .xensource.com>|Subject:=20Re:=20[Xen-devel]=20[Patch]=20 continue_hypercall_on_cpu=20rework=20using=09tasklets |References:=20<C7EB2A3F.11376%keir.fraser@xxxxxxxxxxxxx> |In-Reply-To:=20<C7EB2A3F.11376%keir.fraser@xxxxxxxxxxxxx >|Content-Transfer-Encoding:=207bit; bh=qKapcOPB45CCZxEf+xY1W2stniXhxH/N9u/sxMYbBTk=; b=ejccWApL4cc66Us6bhSQ0idUOKdPpmyKCXLNrX8Y6iAZnku+7zTftzzI TdFdmAG/LfX9NtMzG2DHBP5LGBCaiitTB4tS+4vXRH7BTLHp1lFcjO05a jxYuD6a1GLxSzVS43fbexL4MX8gbcfl4cKpx3u8eC/N8Ub6Ov3mWtZucb FL3xYtD86NJeXNdrY7Av1epCKngkFZ4mGSmLm72OvXyiEJ9ftkvTqwbee BgU2KXKsUVaPGB+er2toAwGt8qzPi;
Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:X-Enigmail-Version:Content-Type: Content-Transfer-Encoding; b=oqQnOpBsFdplrXWyNRdM47bCXjMsDbb6RZ1LV2MR+vEb+JYR9b3/2AxE 0qn6TrUuWd91C3ww2HWEiKQuTf4dIq6tpcIruDsWkNKeoSrP2hbEXZu3x 1SvzfcUdNh3U+XqgcnNTqBLhzRecaVPn5csm5ZIQGEpXB//uFGmEUXENp 2m+2bisyNVzs+uxd83QXjV9TvxVVv2/eaFuRnWsK9QpHuegfRCKRBU9zv 39LHPsf3g+K/PiQxKrm+2GjQtEYmA;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C7EB2A3F.11376%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Fujitsu Technology Solutions
References: <C7EB2A3F.11376%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707)
Keir Fraser wrote:
> On 14/04/2010 07:58, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:
> 
>>> The per-cpu area method should work fine, since Xen is non-preemptive? I
>>> don't think the concurrency you are concerned about can happen.
>> The tasklet knows only on which cpu it is running, so the data has to be
>> stored on the target cpu. And one pcpu can be the target of concurrent calls
>> from different calling cpus...
> 
> A tasklet also takes an arbitrary ulong parameter, which you can cast to a
> pointer to your informational structure. The parameter is specified via
> tasklet_init(). That should suffice.

I'm already using this. The problem is to find the original calling vcpu in
case of a nested call of continue_hypercall_on_cpu() while not conflicting
with concurrent calls from other vcpus which happen to address the same pcpu.


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>