WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 05/11] libxl: Provide libxl_domain_rename

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 05/11] libxl: Provide libxl_domain_rename
From: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>
Date: Fri, 26 Mar 2010 10:34:43 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 26 Mar 2010 03:36:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19372.35641.851620.698017@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1269543854-7780-1-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1269543854-7780-6-git-send-email-ian.jackson@xxxxxxxxxxxxx> <4BAC85E8.3030106@xxxxxxxxxxxxx> <19372.35641.851620.698017@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100204 Icedove/3.0.1
On 26/03/10 10:23, Ian Jackson wrote:
You are confused.  The purpose of this check is to check that the
existing name is as expected, not that the name is not unique
(although the lack of checking that the name is unique is also a bug).

I'm not confused, there's no need to check anything, libxl is here to plumb whatever name the user of the library has chosen for its domain into a xenstore entry: the name is opaque to libxl, and should remains as such.

if you want some kind of migration lock, put in xl where you define the policy.

0 is a perfectly acceptable null pointer constant.

working != acceptable.

--
Vincent

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>