This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Xen 4.0.0x allows for data corruption in Dom0

To: Jan Beulich <JBeulich@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] Xen 4.0.0x allows for data corruption in Dom0
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 09 Mar 2010 10:17:55 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Joanna Rutkowska <joanna@xxxxxxxxxxxxxxxxxxxxxx>, Daniel Stodden <Daniel.Stodden@xxxxxxxxxx>
Delivery-date: Tue, 09 Mar 2010 02:19:10 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B962DC5020000780003371B@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acq/cWz1/AX53RYdSQK14utNL+jbswAAFuSb
Thread-topic: [Xen-devel] Xen 4.0.0x allows for data corruption in Dom0
User-agent: Microsoft-Entourage/
On 09/03/2010 10:15, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>>>> "Jan Beulich" <JBeulich@xxxxxxxxxx> 09.03.10 10:37 >>>
>> How about these being vcpu_time_info structures? The fields
>> appear to all make sense. The only thing not matching this would
>> be a few differently looking corruption entries sent earlier by Joanna,
>> so this may not be the only thing. But it would explain why with 3.4.2
>> the issue is not present.
> In particular I think the update_vcpu_system_time() invocation
> in schedule() isn't right - VCPUOP_register_vcpu_time_memory_area
> taking a virtual address, this call must not happen before
> context_switch().
> And btw., 32-on-64 also seems to be broken for
> VCPUOP_register_vcpu_time_memory_area (since 64-bit Xen reads
> the full 64-bit field).

Yeah, agreed. We'll stub it out for 4.0.0 I think. Things work quite okay
without it.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>