This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][XEN] p2m cleanup: remove unused function

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][XEN] p2m cleanup: remove unused function
From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Date: Wed, 3 Mar 2010 11:25:10 +0000
Cc: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 03 Mar 2010 03:25:58 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=HTtELHthge8Zs/xqgElZWZiSoMe+JTXmN5hogvTFSZw=; b=gNYXU9l3HFQrmOx7+8VZuT7Qek22wgIlLsvLGuLg7mNfk4ZGKYISuTXU/UFBtP2kDW oWlsj4uj12LpdEccJV06fFO8Xg7HMKfmDTweAtBiNShOsh19+8UMooR6aDB3Gvs59uxg 0OOhZr/4ZLQN1DdOMTQRHqpOwaq+ypyZj1l2w=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=F+oJBLcQMPnhcQLW3nfzpVA1do31F5NjyV/dOi7TX2p6oLLx67SjGxDGXK3+NUUa5N c6JILpxY7VLBKD4lbxPaWIwaW0NhyV6jDyfYhm/EmIuNNF1Wg+96wuWRqYrqtcEDN3Gq RXdPu04m/t56/uaIXRpsBV4eVI4RATpkNyj20=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C7B30376.BA48%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201003021820.52535.Christoph.Egger@xxxxxxx> <C7B30376.BA48%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
I thought the whole point of gfn_to_mfn_current() was that it can walk
the p2m table more efficiently if the domain in question is current.
This isn't true with EPT-HAP, but I thought that it was true for both
shadowed and NPT-HAP.  Is this no longer the case?


On Tue, Mar 2, 2010 at 6:03 PM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:
> On 02/03/2010 17:20, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
>> Attached patch removes gfn_to_mfn_current(). It is redundant and effectively
>> unused.
> Hm, well, it's unused after your patch, but used a fair bit right now. It'll
> need an Ack from Tim Deegan, who's on holiday until middle of next week.
>> All remaining users now use proper replacement function.
>> => No functional change.
>> While here, silence stdvga
> Is that a bug fix? Anyhow would belong in a separate properly explained
> patch.
>> and use page_mode_hap()
>> consequently.
> I see you change over to using page_mode_hap() in a few places. I wasn't
> sure on the justification. If you could get rid of
> arch.hvm_domain.hap_enabled entirely that might make it seem more
> worthwhile. Again, it would need Ack from Tim.
>  -- Keir
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>