Re: [Xen-devel] [PATCH][XEN] p2m cleanup: remove unused function

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

I thought the whole point of gfn_to_mfn_current() was that it can walk
the p2m table more efficiently if the domain in question is current.
This isn't true with EPT-HAP, but I thought that it was true for both
shadowed and NPT-HAP.  Is this no longer the case?

 -George

On Tue, Mar 2, 2010 at 6:03 PM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:
> On 02/03/2010 17:20, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
>
>> Attached patch removes gfn_to_mfn_current(). It is redundant and effectively
>> unused.
>
> Hm, well, it's unused after your patch, but used a fair bit right now. It'll
> need an Ack from Tim Deegan, who's on holiday until middle of next week.
>
>> All remaining users now use proper replacement function.
>> => No functional change.
>>
>> While here, silence stdvga
>
> Is that a bug fix? Anyhow would belong in a separate properly explained
> patch.
>
>> and use page_mode_hap()
>> consequently.
>
> I see you change over to using page_mode_hap() in a few places. I wasn't
> sure on the justification. If you could get rid of
> arch.hvm_domain.hap_enabled entirely that might make it seem more
> worthwhile. Again, it would need Ack from Tim.
>
>  -- Keir
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel