This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][XEN] p2m cleanup: remove unused function

To: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][XEN] p2m cleanup: remove unused function
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 02 Mar 2010 18:03:34 +0000
Delivery-date: Tue, 02 Mar 2010 10:04:41 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201003021820.52535.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acq6LPzY3b+WvjcFQaajK3f2hyYpmgABa+9M
Thread-topic: [Xen-devel] [PATCH][XEN] p2m cleanup: remove unused function
User-agent: Microsoft-Entourage/
On 02/03/2010 17:20, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> Attached patch removes gfn_to_mfn_current(). It is redundant and effectively
> unused.

Hm, well, it's unused after your patch, but used a fair bit right now. It'll
need an Ack from Tim Deegan, who's on holiday until middle of next week.

> All remaining users now use proper replacement function.
> => No functional change.
> While here, silence stdvga

Is that a bug fix? Anyhow would belong in a separate properly explained

> and use page_mode_hap()
> consequently.

I see you change over to using page_mode_hap() in a few places. I wasn't
sure on the justification. If you could get rid of
arch.hvm_domain.hap_enabled entirely that might make it seem more
worthwhile. Again, it would need Ack from Tim.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>