Re: [Xen-devel] current not very current (vs curr_vcpu)

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 23/02/2010 19:46, "Mukesh Rathor" <mukesh.rathor@xxxxxxxxxx> wrote:

> struct cpu_user_regs *regs = guest_cpu_user_regs(); <------
> 
> The cpu is clearly running idle_vcpu, so current is correctly pointing
> to idle vcpu. But guest_mode() is showing guest mode incorrectly.
> 
> I'm not much familiar with ns16550 stuff, so cant' think of a fix other
> than just setting regs to current stack pointer in ns16550_poll().
> 
> __asm__ ( "movq %%rsp,%0" : "=r" (val));
> struct cpu_user_regs *regs = val;
> 
> Let me know if you like the fix and I'll submit a patch.

Given the only thing this apparently affected was some of your own ad-hoc
debug code, do we really care about this at all? We can probably happily
just leave it.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel