WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [xen-devel][PATCH] PV driver compatibility

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [xen-devel][PATCH] PV driver compatibility
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 22 Jan 2010 08:03:17 +0000
Cc: ksrinivasan <ksrinivasan@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 22 Jan 2010 00:04:10 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1264145504.21707.79.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqbNPUkUnG8JnKeT8yeSC3waycWaAABGWFF
Thread-topic: [xen-devel][PATCH] PV driver compatibility
User-agent: Microsoft-Entourage/12.23.0.091001
On 22/01/2010 07:31, "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx> wrote:

> Yes, that's possible. I notice that I defined XEN_IOPORT_LINUX_PRODNUM
> and XEN_IOPORT_LINUX_DRVVER but then hardcode 0xdead and 0xbeef where
> they should be used, which suggests I wasn't quite ready to send the
> patch...

Hm, do you want to keep the deadbeef, or pick a nicer value, or remove the
patch?

> The protocol allows for coarse grained selection of which devices to
> unplug:
> 6) The drivers write a two-byte bitmask of devices to unplug to IO
>    port 0x10.  The defined fields are:

Well, the flexibility is nice, but not a feature that driver currently
actually uses.

My default action right now will be to add a module option to specify
selective or complete flushing, keep the patch, but only fail to load
drivers if flush is requested but not possible, otherwise just warn.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel