[Xen-devel] [PATCH] x86: check if desc->action is NULL when unbi

To:	Keir Fraser <keir.fraser@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] x86: check if desc->action is NULL when unbinding guest pirq
From:	"Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date:	Fri, 22 Jan 2010 16:01:44 +0800
Accept-language:	zh-CN, en-US
Acceptlanguage:	zh-CN, en-US
Cc:
Delivery-date:	Fri, 22 Jan 2010 00:03:26 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcqbOSOeIu67pGcuT8Gh3oiBq6xZlw==
Thread-topic:	[PATCH] x86: check if desc->action is NULL when unbinding guest pirq

Before igb PF driver is unloaded, dom0 doesn't unload igbvf driver
automatically. When igb drver is unloaded, it invokes the
PHYSDEVOP_manage_pci_remove hypercall to remove the VFs and xen frees the msi
irqs by pci_cleanup_msi() -> ... -> dynamic_irq_cleanup() and sets the
desc->action to NULL.
igbvf driver knows the VF is disappearing via a hook ndo_stop() in dev_close()
and tries to unbind the pirq and xen would crash as the desc->action
is NULL now.
The patch adds the checking for this.

Thanks,
-- Dexuan

check_desc_action.patch
Description: check_desc_action.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] [PATCH] x86: check if desc->action is NULL when unbinding gu