Re: [Xen-devel] Re: A question about changeset 20621:f9392f6eda79 and Discontinuous online node

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 06/01/2010 09:28, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

>> Keir, thanks for pointing out this.The API is sufficient. We only need
>> changes
>> to python side to understand this. One minor thing is, maybe we need change
>> the nr_nodes from number of online node to the maxium of online node id,
>> otherwise, xc.physinfo may have no idea when iterate the node_to_memory
>> information (will it be possible the a node has only memory populated, while
>> no CPU populated?)
> 
> Yes, I think actually that would be a bug fix, given how tools currently use
> the nr_nodes field. Feel free to send a patch as part of your fix-up work: I
> don't think even changing the field name is necessary, but we can add a
> comemnt to sysctl.h.

Actually I think we should change the nr_cpus field in the same way, and may
as well change their names to max_cpu_id and max_node_id. I'll look into
this myself.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel