Re: [Xen-devel] xen_tlb_flush_all mfn validation panic

[Kieran Mansley <kmansley@xxxxxxxxxxxxxx>]

On Thu, 2009-12-24 at 16:01 +0000, Keir Fraser wrote:
> On 24/12/2009 15:32, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
> 
> > On 24/12/2009 15:06, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote:
> > 
> >> The initial "bad gmfn" message seems to be due to an attempt to validate
> >> the mfn argument to the mmuext_op.  It's not surprising to me that this
> >> fails as xen_tlb_flush_all doesn't supply an mfn argument - it's not
> >> needed for the MMUEXT_TLB_FLUSH_ALL command.  Is there something that is
> >> supposed to mean that the mfn argument should be valid even when not
> >> explicitly set by the caller, or is the validation of the mfn for all
> >> mmuext_op commands a bug?
> > 
> > The explicit check for INVALID_MFN is new, and that is obviously a bug. I
> > will sort out a suitable fix for this.
> 
> Should be fixed by c/s 20723.

Great, thanks.  I'll retest after Christmas.

Kieran 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel