WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: is_xen_swiotlb_buffer() vs CONFIG_HIGHMEM

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: [Xen-devel] Re: is_xen_swiotlb_buffer() vs CONFIG_HIGHMEM
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 15 Dec 2009 10:34:01 -0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Tue, 15 Dec 2009 10:34:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B2661970200007800025B69@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B2661970200007800025B69@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091203 Fedora/3.0-3.13.rc2.fc12 Thunderbird/3.0
On 12/14/2009 07:02 AM, Jan Beulich wrote:
shouldn't is_xen_swiotlb_buffer() also check against e.g. highstart_pfn
to deal with wrap-around potentially leading to aliasing of
[xen_io_tlb_start,xen_io_tlb_end)?

So what you're saying is that if the pfn is for a high page, then "__va(pfn << PAGE_SHIFT);" is simply invalid. The resulting addr is undefined, and may end up erroneously aliasing with the xen tlb buffer.

Do I understand your concern properly?

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>