WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] xen: reduce severity of message about using

On Thu, 2009-12-03 at 20:13 +0000, Jeremy Fitzhardinge wrote:
> 
> >       BUG_ON(flags & (GTF_accept_transfer | GTF_reading |
> >                       GTF_writing | GTF_sub_page |
> GTF_permit_access));
> > -     BUG_ON(grant_table_version == 1);
> > +     if (grant_table_version == 1)
> >   
> 
> Rather than having all these version tests, would it make sense to
> have a grant_ops vector? 

I was looking at these today and reckon you could go a long way with a
couple of accessor macros towards avoiding most of the version checks.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel