WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] xen: reduce severity of message about using v1 grant

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] xen: reduce severity of message about using v1 grant tables.
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Wed, 2 Dec 2009 19:28:18 +0000
Cc: Steven Smith <Steven.Smith@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Ian Campbell <ijc@xxxxxxxxxxxxxx>
Delivery-date: Wed, 02 Dec 2009 11:30:15 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
From: Ian Campbell <ijc@xxxxxxxxxxxxxx>

It's hardly the end of the world...

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Cc: Steven Smith <Steven.Smith@xxxxxxxxxxxxx>
---
 drivers/xen/grant-table.c |   19 ++++++++++---------
 1 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
index 2240adf..85ce951 100644
--- a/drivers/xen/grant-table.c
+++ b/drivers/xen/grant-table.c
@@ -699,21 +699,22 @@ static void gnttab_request_version(void)
 
        gsv.version = 2;
        rc = HYPERVISOR_grant_table_op(GNTTABOP_set_version, &gsv, 1);
-       if (rc == 0) {
+       if (rc == 0)
                grant_table_version = 2;
-               printk(KERN_NOTICE "Using V2 grant tables.\n");
-       } else {
+       else {
                if (grant_table_version == 2) {
-                       /* If we've already used version 2 features,
-                          but then suddenly discover that they're not
-                          available (e.g. migrating to an older
-                          version of Xen), almost unbounded badness
-                          can happen. */
+                       /*
+                        * If we've already used version 2 features,
+                        * but then suddenly discover that they're not
+                        * available (e.g. migrating to an older
+                        * version of Xen), almost unbounded badness
+                        * can happen.
+                        */
                        panic("we need grant tables version 2, but only version 
1 is available");
                }
                grant_table_version = 1;
-               printk(KERN_WARNING "Using legacy V1 grant tables; upgrade to a 
newer version of Xen.\n");
        }
+       printk(KERN_INFO "Grant tables using version %d layout.\n", 
grant_table_version);
 }
 
 static int gnttab_map(unsigned int start_idx, unsigned int end_idx)
-- 
1.6.5.3


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel