WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in msi_

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Miroslav Rezanina <mrezanin@xxxxxxxxxx>
Subject: RE: [Xen-devel] RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in msi_msg_read_remap_rte with acpi=off
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Mon, 19 Oct 2009 22:18:04 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 19 Oct 2009 07:18:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C70213CA.17E4E%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C7021168.17E44%keir.fraser@xxxxxxxxxxxxx> <C70213CA.17E4E%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpQrfYaPJP/l2nLTzW4nI+GixWepgAA3Y3kAABH+R0AAFrlEgAENZwQ
Thread-topic: [Xen-devel] RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in msi_msg_read_remap_rte with acpi=off
Keir Fraser wrote:
> On 19/10/2009 12:51, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
> 
>>> Got a backtrace and Xen boot params? If you pass acpi=off, then
>>> disable_acpi() is invoked, and this sets acpi_disabled. If
>>> acpi_disabled=1, then iommu_setup() sets iommu_enabled=0. If
>>> iommu_enabled=0 then I think all the update_ire_from_* and similar
>>> hooks get disabled in the callers. So something unexpected must be
>>> happening. 
>> 
>> Hmmm, perhaps this could be an early boot-time crash before
>> iommu_setup() is even called? Perhaps moving the if(acpi_disabled)
>> iommu_enabled=0 somewhere early-ish in setup.c:__start_xen(), with a
>> warning message, would be the right thing to do in that case (e.g.,
>> immediately after the call to cmdline_parse()).
> 
> After some more hmmm'ing I have to admit your original patch was
> actually the best way to go. :-)
> 
> All other callers of acpi_find_matched_drhd_unit() that you didn't
> patch already check for NULL return, so it's presumably expected as a
> possibility. And it is okay for msi_msg_{read,write}_remap_rte() to
> bail silently if they cannot determine there's any work to do, since
> they operate as potential modifiers to operations which are primarily
> implemented in their callers. 
> 
> So sorry about that. I'll revert Dexuan's patch.
> 
>  -- Keir

But, can't you reproduce the crash I mentioned before?
Please see the attached crash log -- I'm using c/s 20341:ea34183c5c11 and with 
"iommu=1 acpi=off" and I use a DQ35 host.

Actually what I care is the " if ( acpi_disabled ) iommu_enabled = 0".

Thanks,
-- Dexuan

Attachment: crash.log
Description: crash.log

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>