WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in msi_

To: Miroslav Rezanina <mrezanin@xxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in msi_msg_read_remap_rte with acpi=off
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Mon, 19 Oct 2009 19:31:27 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 19 Oct 2009 04:31:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <536397239.366121255951138900.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1751031413.365351255949403376.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <536397239.366121255951138900.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpQrgCzBhDgFkIqRoCEcmMdXea5+QAAVokA
Thread-topic: [Xen-devel] RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in msi_msg_read_remap_rte with acpi=off
Miroslav Rezanina wrote:
>>> 
>>> Hi Dexuan,
>>> you're right. We should print warning. In your patch, I do not
>>> understand why you put comment only in setup_dom0_devices function.
>>> There is more calling of domain_context_mapping and we check NULL
>>> also in domain_context_unmap and reassign_device_ownership. We
>>> should put warning in there too, shouldn't we?
>> 
>> The warnings are silly, if we believe find_matched_drhd_unit() should
>> not
>> return NULL in those cases. Since obviously we wouldn't know what to
>> do in
>> that case: bailing and doing nothing, while convenient and requiring
>> little
>> thought to implement, probably causes other subtler problems later on
>> since
>> those remap functions are supposed to actually do something! Crashing
>> immediately is the nice thing to do here: nice for the poor developer
>> who
>> may have to debug this case sometime in the future, in the hopefully
>> unlikely event our belief turns out to be false.
>> 
>> I'll be applying Dexuan's original replacement patch.
>> 
>>  -- Keir
>> 
> 
> I retest version with removed NULL checks and in this case, my system
> crashes. So there has to be checks for NULL or something else is
> wrong. 
> 
> Regards,
> Mirek
Hi Mirek, 
Do you mean: with changeset 20338: 5f28661bb2bb and "acpi=off iommu=1", xen 
crashes in your host?
Can you post the entire serial log?

Thanks,
-- Dexuan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>