WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: vtsc in domain builder

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: vtsc in domain builder
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 16 Sep 2009 08:25:59 +0100
Cc:
Delivery-date: Wed, 16 Sep 2009 00:27:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <7ce1181a-bd58-4fd3-adca-a6324abf90fb@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aco2XN0JZLnetOakSrafej3ViSx5eAAQhLOM
Thread-topic: vtsc in domain builder
User-agent: Microsoft-Entourage/12.20.0.090605
On 16/09/2009 00:32, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>> Was this change due to some backward compatibility reason?
> 
> I found the compatibility issue describe here:
> 
> http://xen.markmail.org/message/usjxnjyp3csm3uct?q=superpages+date:200907
> 
> So it seems even more important that I somehow claim
> a field (or at least a bit) in struct xc_dom_image.
> Any help to get this right would be appreciated
> as getting it wrong clearly has some non-obvious
> consequences.

Well, the main issue was the original patch broke API compatibility. Fixing
ABI compatibility in the fixup patch was just gravy.

I suggest you split the superpages int8_t into a bitfield, e.g:
uint8_t superpages:1, vtsc:1;
Putting superpages first should maintain compatibility as far as possible.
The bitfield has to be switched to be unsigned - we got bit by that before.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>