Re: [Xen-devel] remover edundant call of socket.close()

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

Socket.SHUT_RDWR is not available in Python 2.3. Sock.close() should free
the underlying socket fd, which sock.shutdown() will not do (if these
methods behave as their underlying Unix equivalents).

 -- Keir

On 07/09/2009 03:55, "James Song" <jsong@xxxxxxxxxx> wrote:

> Hi,
>     After shutdown read and write side, sock needn't call close().  Moreover,
> use socket.SHUT_RDWR instead of 2 would enhace the readability of the code.
> 
> Signed-off-by: James Song <jsong@xxxxxxxxxx>
> 
> diff -r ead107bc25cb tools/python/xen/xend/XendDomain.py
> --- a/tools/python/xen/xend/XendDomain.py       Fri Sep 04 08:43:05 2009 +0100
> +++ b/tools/python/xen/xend/XendDomain.py       Mon Sep 07 10:33:40 2009 +0800
> @@ -1353,8 +1353,7 @@
>                  XendCheckpoint.save(p2cwrite, dominfo, True, live, dst,
>                                      node=node)
>              finally:
> -                sock.shutdown(2)
> -                sock.close()
> +                sock.shutdown(socket.SHUT_RDWR)
> 
>              os.close(p2cread)
>              os.close(p2cwrite)
> @@ -1379,8 +1378,7 @@
>                  XendCheckpoint.save(sock.fileno(), dominfo, True, live,
>                                      dst, node=node)
>              finally:
> -                sock.shutdown(2)
> -                sock.close()
> +                sock.shutdown(socket.SHUT_RDWR)
> 
>      def domain_save(self, domid, dst, checkpoint=False):
>          """Start saving a domain to file.
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel