RE: [Xen-devel] [PATCH] Don't free irqaction for com irq when release irq.

[Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>]

Oops yes, thanks for pointing that out.  This won't
be the first or last time I've been fooled by that
convention.

For the sake of good programming practices and
(self-)documentation, since "don't free" is
a rare exception rather than the rule, may
I suggest changing the name/sense of the variable
in the struct to "dont_free", for which zero is
a reasonable default, and just enabling
it for the com irqs?

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxxxx]
> Sent: Thursday, September 03, 2009 10:03 AM
> To: Dan Magenheimer
> Cc: Keir Fraser; Xiantao Zhang; Xen
> Subject: RE: [Xen-devel] [PATCH] Don't free irqaction for com irq when
> release irq.
> 
> 
> >>> Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> 03.09.09 17:48 >>>
> >Unless I missed something, it looks like Keir's modified
> >version of this patch (20153) neglects to set the
> >free_on_release=0 for the com irqs.
> 
> ns16550_com[] starts out as being all zero, hence there's no need to
> explicitly clear that flag.
> 
> Jan
> 
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel