WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] Don't free irqaction for com irq when release ir

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Don't free irqaction for com irq when release irq.
From: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
Date: Thu, 3 Sep 2009 09:26:08 -0700 (PDT)
Cc: Xen <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, Xiantao Zhang <xiantao.zhang@xxxxxxxxx>
Delivery-date: Thu, 03 Sep 2009 09:26:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4AA004E6020000780001340A@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Oops yes, thanks for pointing that out.  This won't
be the first or last time I've been fooled by that
convention.

For the sake of good programming practices and
(self-)documentation, since "don't free" is
a rare exception rather than the rule, may
I suggest changing the name/sense of the variable
in the struct to "dont_free", for which zero is
a reasonable default, and just enabling
it for the com irqs?

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxxxx]
> Sent: Thursday, September 03, 2009 10:03 AM
> To: Dan Magenheimer
> Cc: Keir Fraser; Xiantao Zhang; Xen
> Subject: RE: [Xen-devel] [PATCH] Don't free irqaction for com irq when
> release irq.
> 
> 
> >>> Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> 03.09.09 17:48 >>>
> >Unless I missed something, it looks like Keir's modified
> >version of this patch (20153) neglects to set the
> >free_on_release=0 for the com irqs.
> 
> ns16550_com[] starts out as being all zero, hence there's no need to
> explicitly clear that flag.
> 
> Jan
> 
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel