WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [PATCH] Don't free irqaction for com irq when release ir

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Xen <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH] Don't free irqaction for com irq when release irq.
From: "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
Date: Thu, 3 Sep 2009 17:38:35 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc:
Delivery-date: Thu, 03 Sep 2009 02:42:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C6C51D46.13BFA%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <706158FABBBA044BAD4FE898A02E4BC201C43C4D4E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C6C51D46.13BFA%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcosTRSUhlwzY5qiQZ28V99eTxDLSAAEK3oeAAb6JIA=
Thread-topic: [PATCH] Don't free irqaction for com irq when release irq.
No, host S3 issue is caused by ioapic suspend/resume in dom0.  IMO, dom0 
shouldn't perform S3 for ioapic , right ? After fixing that issue, domain S3 
works well. 
Xiantao

-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
Sent: Thursday, September 03, 2009 2:14 PM
To: Zhang, Xiantao; Xen
Subject: Re: [PATCH] Don't free irqaction for com irq when release irq.

On 03/09/2009 05:14, "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx> wrote:

> # HG changeset patch
> # User root@xxxxxxxxxxxxxxxxxxxxx
> # Date 1251916103 14400
> # Node ID 49e847aed58dde35f8a0f909999d01d97be6f531
> # Parent  3b7cbf32fee909d860daacf70b8c3b97eaf036b5
> x86: com devices's irqaction shouldn't free.
> 
> Since irqs of serial devices are initialized in early Xen and
> its irqaction is not allocated from heap, so doesn't need free
> in release irq logic.
> Signed-off-by: Xiantao Zhang <xiantao.zhang@xxxxxxxxx>

Does this fix host S3?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel