|
|
|
|
|
|
|
|
|
|
xen-devel
RE: [Xen-devel] [RFC] save image file format CHANGE (minor, but feedback
To: |
Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
Subject: |
RE: [Xen-devel] [RFC] save image file format CHANGE (minor, but feedback appreciated) |
From: |
Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> |
Date: |
Thu, 30 Jul 2009 15:59:11 -0700 (PDT) |
Cc: |
Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, Stefano@xxxxxxxxxxxxxxxxxxxx, Gianluca Guida <Gianluca.Guida@xxxxxxxxxxxxx>, John Levon <levon@xxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx> |
Delivery-date: |
Thu, 30 Jul 2009 16:00:07 -0700 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<C697E05F.110DD%keir.fraser@xxxxxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Well for PV guests, the p2m table is definitely assumed
to be first. Are you saying, I can/should put the tmem
stuff between the p2m table and the mapped data pages?
If so, cool, I will give that a try. Thanks!
Dan
> -----Original Message-----
> From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
> Sent: Thursday, July 30, 2009 4:42 PM
> To: Dan Magenheimer; Xen-Devel (E-mail)
> Cc: Tim Deegan; Gianluca Guida; Stefano Stabellini; John Levon;
> Stefano@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [RFC] save image file format CHANGE
> (minor, but
> feedback appreciated)
>
>
> On 30/07/2009 23:05, "Dan Magenheimer"
> <dan.magenheimer@xxxxxxxxxx> wrote:
>
> > It appears that the "next negative number as marker"
> > mechanism only works for data that trails the last
> > iteration of (mapped) pages, and thus works only after
> > the domain has been suspended. (True?)
>
> No. It so happens that all such markers are emitted after
> saved pages right
> now, but you can see in xc_domain_restore.c that markers are
> detected right
> at the top of the read pages loop. You could add a new marker, emit it
> before any pages in xc_domain_save.c, and pick it up just fine in the
> restore loop. You'd read the rest of your stuff and act on
> it, then do a C
> 'continue' to kick off the next loop iteration, which would
> presumably start
> reading ordinary saved memory pages.
>
> Your patch is definitely not required.
>
> -- Keir
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|