| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [RFC] save image file format CHANGE (minor, but feedback
|
To: |
Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [RFC] save image file format CHANGE (minor, but feedback appreciated) |
|
From: |
Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
|
Date: |
Thu, 30 Jul 2009 23:42:23 +0100 |
|
Cc: |
Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, Gianluca Guida <Gianluca.Guida@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, John Levon <levon@xxxxxxxxxxxxxxxxx>, Stefano |
|
Delivery-date: |
Thu, 30 Jul 2009 15:42:49 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<543bbd6d-0c17-41d1-84db-68592a60faf9@default> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AcoRYg1tkPgll2ZgRlWJZcD44oUWWwABPOZ9 |
|
Thread-topic: |
[Xen-devel] [RFC] save image file format CHANGE (minor, but feedback appreciated) |
|
User-agent: |
Microsoft-Entourage/12.20.0.090605 |
On 30/07/2009 23:05, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:
> It appears that the "next negative number as marker"
> mechanism only works for data that trails the last
> iteration of (mapped) pages, and thus works only after
> the domain has been suspended. (True?)
No. It so happens that all such markers are emitted after saved pages right
now, but you can see in xc_domain_restore.c that markers are detected right
at the top of the read pages loop. You could add a new marker, emit it
before any pages in xc_domain_save.c, and pick it up just fine in the
restore loop. You'd read the rest of your stuff and act on it, then do a C
'continue' to kick off the next loop iteration, which would presumably start
reading ordinary saved memory pages.
Your patch is definitely not required.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home