WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: compat tool problem with new tmem save/restore tmem_op s

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: [Xen-devel] RE: compat tool problem with new tmem save/restore tmem_op struct
From: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
Date: Wed, 29 Jul 2009 09:00:48 -0700 (PDT)
Cc: "Xen-Devel \(E-mail\)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 29 Jul 2009 09:01:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A700E36020000780000D0A9@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> Would be good if you pointed out *how* it fails

Sorry, I should have thought to send the make output
with the first message.  See attached.  (Warning,
this gcc output has some strange escape characters
for quotes so may appear to be a binary file.)

> And (after having read you follow up mail) I'd think 
> flattening the structure
> isn't the right thing to do.

Agree.  I'll continue debugging with the flattened
structure and then switch back to the nested union
if/when you are able to fix the tool.  Switching
back will hopefully be syntactic only with search/replace.

Thanks,
Dan

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxxxx]
> Sent: Wednesday, July 29, 2009 12:54 AM
> To: Dan Magenheimer
> Cc: Xen-Devel (E-mail)
> Subject: Re: compat tool problem with new tmem save/restore tmem_op
> struct
> 
> >>> Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> 28.07.09 20:00 >>>
> >I'm trying to implement save/restore code for tmem
> >and to do so I need to pass other variants of the
> >tmem_op struct between tools (dom0) and the hypervisor
> >so I made the changes below to struct tmem_op.
> >Unfortunately the nested union seems to break your compat
> >translation tool.  Is this an easy fix for your
> >tool?  If not, I suppose I can recode to only
> >use a single level of union.
> 
> Would be good if you pointed out *how* it fails - it doesn't 
> look as if it
> should have a problem with such a layout (and hence if it 
> does I'd think
> it should be fixed). I'll try it out myself once I can get to 
> it, but it's unlikely
> that this would be earlier than next week.
> 
> And (after having read you follow up mail) I'd think 
> flattening the structure
> isn't the right thing to do.
> 
> Jan

Attachment: make.out
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel