[Xen-devel] RE: compat tool problem with new tmem save/restore tmem_op struct

[Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>]

> Would be good if you pointed out *how* it fails

Sorry, I should have thought to send the make output
with the first message.  See attached.  (Warning,
this gcc output has some strange escape characters
for quotes so may appear to be a binary file.)

> And (after having read you follow up mail) I'd think 
> flattening the structure
> isn't the right thing to do.

Agree.  I'll continue debugging with the flattened
structure and then switch back to the nested union
if/when you are able to fix the tool.  Switching
back will hopefully be syntactic only with search/replace.

Thanks,
Dan

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxxxx]
> Sent: Wednesday, July 29, 2009 12:54 AM
> To: Dan Magenheimer
> Cc: Xen-Devel (E-mail)
> Subject: Re: compat tool problem with new tmem save/restore tmem_op
> struct
> 
> >>> Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> 28.07.09 20:00 >>>
> >I'm trying to implement save/restore code for tmem
> >and to do so I need to pass other variants of the
> >tmem_op struct between tools (dom0) and the hypervisor
> >so I made the changes below to struct tmem_op.
> >Unfortunately the nested union seems to break your compat
> >translation tool.  Is this an easy fix for your
> >tool?  If not, I suppose I can recode to only
> >use a single level of union.
> 
> Would be good if you pointed out *how* it fails - it doesn't 
> look as if it
> should have a problem with such a layout (and hence if it 
> does I'd think
> it should be fixed). I'll try it out myself once I can get to 
> it, but it's unlikely
> that this would be earlier than next week.
> 
> And (after having read you follow up mail) I'd think 
> flattening the structure
> isn't the right thing to do.
> 
> Jan

make.out
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel