WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0

To: "echo@xxxxxxxxxxxx" <echo@xxxxxxxxxxxx>, Christoph Egger <Christoph.Egger@xxxxxxx>, Steven Maresca <steve.maresca@xxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0
From: "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>
Date: Tue, 7 Jul 2009 08:37:27 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "keir.fraser@xxxxxxxxxxxxx" <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 06 Jul 2009 17:38:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1246896129.5517.287.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EADF0A36011179459010BDF5142A457501C9F46DA5@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <200907061534.31677.Christoph.Egger@xxxxxxx> <EADF0A36011179459010BDF5142A457501C9F46DBA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <200907061749.29633.Christoph.Egger@xxxxxxx> <1246896129.5517.287.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acn+UyaZWk8AQbn9R2yDqO7273qohAAR05Gg
Thread-topic: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0
Using "/sys/bus/xen-backend/devices/" is fine, formerly I didn't notice there 
was a link in this directory. Thanks!

Best Regards, 
-- Dongxiao

-----Original Message-----
From: Tim Post [mailto:echo@xxxxxxxxxxxx] 
Sent: Tuesday, July 07, 2009 12:02 AM
To: Christoph Egger
Cc: Xu, Dongxiao; xen-devel@xxxxxxxxxxxxxxxxxxx; keir.fraser@xxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0

Hi,

On Mon, 2009-07-06 at 17:49 +0200, Christoph Egger wrote:
> This patch is good.
> 

The following is going to break xenstat on almost every forward port of
2.6.18.8 (including Andy's 2.6.30 vanilla port):


+       if (strncmp(system_info.release, "2.6.18.8-xen", 
+               sizeof("2.6.18.8-xen")) == 0)
+               sysfs_vbd_path = "/sys/devices/xen-backend/";
+       else
+               sysfs_vbd_path = "/sys/devices/";
+

I would really recommend considering just
using /sys/bus/xen-backend/devices, as Stephen noted.

Cheers,
--Tim



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel