Re: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0

[Christoph Egger <Christoph.Egger@xxxxxxx>]

This patch is good.

Christoph


On Monday 06 July 2009 16:08:10 Xu, Dongxiao wrote:
> Thanks for comments. The revised patch is attached!
>
> Best Regards,
> -- Dongxiao
>
> -----Original Message-----
> From: Christoph Egger [mailto:Christoph.Egger@xxxxxxx]
> Sent: Monday, July 06, 2009 9:35 PM
> To: xen-devel@xxxxxxxxxxxxxxxxxxx
> Cc: Xu, Dongxiao; keir.fraser@xxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0
>
> On Monday 06 July 2009 15:08:06 Xu, Dongxiao wrote:
> > Xentop encounters error in pv-ops domain0, because the VBD path in sysfs
> > changes to "/sys/devices" Also delete the macro in xenstat_netbsd.c,
> > because it is not used.
> >
> > Signed-off-by: Dongxiao Xu <dongxiao.xu@xxxxxxxxx>
>
> Can you move the Linux specific code you add in xentop.c into
> xenstat_linux.c, please? This is an abstraction violation, otherwise.
>
> Thanks,
> Christoph



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel