WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] 32-on-64 support in xen-unstable?

To: Chris Lalancette <clalance@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] 32-on-64 support in xen-unstable?
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 06 Jul 2009 16:23:24 +0100
Cc:
Delivery-date: Mon, 06 Jul 2009 08:25:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A5207B1.3030808@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acn+RK9CrTL9BP0rS9myzcxvVRP5GQACQSU6
Thread-topic: [Xen-devel] 32-on-64 support in xen-unstable?
User-agent: Microsoft-Entourage/12.19.0.090515
On 06/07/2009 15:18, "Chris Lalancette" <clalance@xxxxxxxxxx> wrote:

> However, looking at arch/x86/mm.c:mod_l4_entry(), it returns 0 on success and
> <
> 0 on error.  It seems to me that booting a 32-bit PV guest is always going to
> fall into the !okay check on success, when it really shouldn't.

You didn't spot the '== 0' tacked on the end of that long ternary
expression?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>