WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] 32-on-64 support in xen-unstable?

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] 32-on-64 support in xen-unstable?
From: Chris Lalancette <clalance@xxxxxxxxxx>
Date: Mon, 06 Jul 2009 16:44:51 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 06 Jul 2009 08:16:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A5228600200007800008FC5@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4A5207B1.3030808@xxxxxxxxxx> <4A5228600200007800008FC5@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Jan Beulich wrote:
>>>> Chris Lalancette <clalance@xxxxxxxxxx> 06.07.09 16:18 >>>
>> Hello,
>>     I've been browsing through the preemptible pagetable stuff, and ran 
>> across
>> a piece of code that I don't understand or is buggy.  Looking at
>> arch/x86/mm.c:new_guest_cr3(), we have this code for 32-on-64 support:
> 
> You probably overlooked the == 0 et the end of the expression:
> 
>>    if ( is_pv_32on64_domain(d) )
>>    {
>>        okay = paging_mode_refcounts(d)
>>            ? 0 /* Old code was broken, but what should it be? */
>>            : mod_l4_entry(
>>                    __va(pagetable_get_paddr(curr->arch.guest_table)),
>>                    l4e_from_pfn(
>>                        mfn,
>>                        (_PAGE_PRESENT|_PAGE_RW|_PAGE_USER|_PAGE_ACCESSED)),
>>                    pagetable_get_pfn(curr->arch.guest_table), 0, 0, curr) == 
>> 0;
>                                                                          ^^^^
> 
> Which basically is equivalent to what you were trying to suggest.

D'oh!  Of course.  I did overlook that, thanks for pointing it out.

-- 
Chris Lalancette

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>