|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
[Xen-devel] Re: [PATCH 06/10] x86/PCI: Enable scanning of all pci	functi
 
| 
To:  | 
Jeremy Fitzhardinge <jeremy@xxxxxxxx> | 
 
| 
Subject:  | 
[Xen-devel] Re: [PATCH 06/10] x86/PCI: Enable scanning of all pci	functions | 
 
| 
From:  | 
Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> | 
 
| 
Date:  | 
Thu, 14 May 2009 12:15:13 -0700 | 
 
| 
Cc:  | 
Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jeremy,	Joerg Roedel <joerg.roedel@xxxxxxx>,	the arch/x86 maintainers <x86@xxxxxxxxxx>,	Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>,	FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>,	Alex Nixon <alex.nixon@xxxxxxxxxx>,	Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>,	Matthew Wilcox <willy@xxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx> | 
 
| 
Delivery-date:  | 
Thu, 14 May 2009 12:15:44 -0700 | 
 
| 
Domainkey-signature:  | 
a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;	h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;	b=Q2OCPd0b5y6/bdxfuxugHEuYVx00qu9cJ4yZ7JHtZ7qqFQk1LMXKyYM6Vgo79DdhQpDzrVircSFSlV4yFR8hfHM8sFnDKRe0uzZB6CO5X7jFCqxFdZoVb63SD8BeUw7g; | 
 
| 
Envelope-to:  | 
www-data@xxxxxxxxxxxxxxxxxxx | 
 
| 
In-reply-to:  | 
<4A0C66DB.9020707@xxxxxxxx> | 
 
| 
List-help:  | 
<mailto:xen-devel-request@lists.xensource.com?subject=help> | 
 
| 
List-id:  | 
Xen developer discussion <xen-devel.lists.xensource.com> | 
 
| 
List-post:  | 
<mailto:xen-devel@lists.xensource.com> | 
 
| 
List-subscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> | 
 
| 
List-unsubscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> | 
 
| 
References:  | 
<1242164891-3859-1-git-send-email-jeremy@xxxxxxxx>	<1242164891-3859-7-git-send-email-jeremy@xxxxxxxx>	<20090513095535.140134e1@jbarnes-g45> <4A0AFE84.2040805@xxxxxxxx>	<20090513102316.5ef3ce4e@jbarnes-g45> <4A0C66DB.9020707@xxxxxxxx> | 
 
| 
Sender:  | 
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx | 
 
 
 
On Thu, 14 May 2009 11:45:47 -0700
Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> Jesse Barnes wrote:
> > Anyway it's not a big deal, this code is already ugly (a 0 define
> > for all arches?  why?) so you shouldn't have to spend too much time
> > cleaning it up.
> >   
> 
> OK, how's this as a delta (I can fold it into the previous patch if 
> you're OK with it):
> 
> Subject: [PATCH] pci: add HAVE_ARCH_PCIBIOS_SCAN_ALL_FNS
> 
> Jesse objected to the "#undef pcibios_scan_all_fns"'s ugliness,
> so replace it with the more common HAVE_ARCH_ idiom.
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
That's slightly better.  It looks like we should just get rid of
pcibios_scan_all_fns altogether, but this is fine for now.
Acked-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
-- 
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 
 |   
 
 | 
    | 
  
  
    |   | 
    |