WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 30 Apr 2009 10:35:17 +0100
Delivery-date: Thu, 30 Apr 2009 02:36:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1241081691.5394.192.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnJcVxmRxnFDvVaR4acDp3RgN75dAABZwkz
Thread-topic: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits
User-agent: Microsoft-Entourage/12.17.0.090302
On 30/04/2009 09:54, "Tim Post" <echo@xxxxxxxxxxxx> wrote:

>> Defining the same thing again but with a different name just for purposes of
>> documentation is pretty barking. I suppose it is perhaps worth a
>> documentation comment in xs.h, but no more than that.
> 
> It is worth a mention... though it seems silly to send a patch that adds
> comments. However, a patch that would convert the comments in xs to
> doxygen format seems more useful, with the appropriate grouping, shorts,
> etc.
> 
> How receptive would you be to that?

I don't have a strong opinion. You can go wild on that if you like, assuming
noone else hates doxygen format for any reason. I added a limits-related
comment to xs.h by the way.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel