WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 29 Apr 2009 19:01:38 +0100
Delivery-date: Wed, 29 Apr 2009 11:02:10 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1241023383.5394.162.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnI6aQ5TGY/yKT0Q6K0GDnPaLQTdQACuZlb
Thread-topic: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits
User-agent: Microsoft-Entourage/12.17.0.090302
On 29/04/2009 17:43, "Tim Post" <echo@xxxxxxxxxxxx> wrote:

> Since xs.h already includes xs_wire, this patch duplicates those limits
> as XS_PAYLOAD_MAX, XS_ABS_PATH_MAX and XS_REL_PATH_MAX. Moving these
> would be a pain, but they really need to be advertised.
> 
> Such limits should be obvious in the headers that people actually use
> outside of the kernel, saving them from wondering what went wrong.
> 
> Added comments direct people to xs_wire.h , in case those limits change.

In terms of documentation, docs/misc/xenstore.txt already does a fine job.
And I think a xen/public/... header is the right place for the limits, since
it is a general documented protocol-level constraint, rather than a
constraint of the particular client library (which is the scope of xs.h
itself).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel