WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2/2] ioemu: don't call xc_deassign_device().

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/2] ioemu: don't call xc_deassign_device().
From: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>
Date: Tue, 28 Apr 2009 15:02:02 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 27 Apr 2009 23:02:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090424174238.B657.27C06F64@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090424173938.B651.27C06F64@xxxxxxxxxxxxxxx> <20090424174238.B657.27C06F64@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Ian,

I sent two patches about the reset of devices.

The patch [1/2] has already applied to Xen.
Could you apply the patch [2/2] to ioemu?

Thanks,
--
Yuji Shimada

On Fri, 24 Apr 2009 17:43:39 +0900
Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx> wrote:

> This patch modifies ioemu not to call xc_deassign_device()
> 
> Thanks,
> --
> Yuji Shimada
> 
> 
> Signed-off-by: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>
> 
> diff --git a/hw/pass-through.c b/hw/pass-through.c
> index 7bd2feb..6a53137 100644
> --- a/hw/pass-through.c
> +++ b/hw/pass-through.c
> @@ -3972,13 +3972,6 @@ static int unregister_real_device(int slot)
>      /* unregister real device's MMIO/PIO BARs */
>      pt_unregister_regions(assigned_device);
>  
> -    /* deassign the dev to dom0 */
> -    bdf |= (pci_dev->bus  & 0xff) << 16;
> -    bdf |= (pci_dev->dev  & 0x1f) << 11;
> -    bdf |= (pci_dev->func & 0x1f) << 8;
> -    if ( (rc = xc_deassign_device(xc_handle, domid, bdf)) != 0)
> -        PT_LOG("Error: Revoking the device failed! rc=%d\n", rc);
> -
>      /* mark this slot as free */
>      php_dev->valid = 0;
>      php_dev->pt_dev = NULL;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel