WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] ioemu: fix INTx disable bit in MSI-INTx translat

To: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] ioemu: fix INTx disable bit in MSI-INTx translation
From: Qing He <qing.he@xxxxxxxxx>
Date: Thu, 16 Apr 2009 17:01:23 +0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 16 Apr 2009 02:00:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090416173137.701B.27C06F64@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1239802852-8480-1-git-send-email-qing.he@xxxxxxxxx> <20090416173137.701B.27C06F64@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.17+20080114 (2008-01-14)
On Thu, 2009-04-16 at 16:44 +0800, Yuji Shimada wrote:
> On Wed, 15 Apr 2009 21:40:52 +0800
> Qing He <qing.he@xxxxxxxxx> wrote:
> 
> > Fix the bug introduced in commit 8c771eb6: when msi-intx
> > translation is enabled, int disable bit in PCI_COMMAND is set.
> > This approach has two issues:
> >     1. for some (buggy) devices, set INTx bit will also disable
> >        MSI so that MSI doesn't work any more.
> >     2. it's never re-enabled when msi translation is turned off.
> >        If the guest uses INTx, it can't receive any interrupts
> >        from then.
> > 
> > This patch leaves INTx disable bit unset if MSI-INTx translation
> > is used.
> 
> I have sent the patch to fix the issue that you pointed out.
> 
> The following patch is.
> http://lists.xensource.com/archives/html/xen-devel/2009-04/msg00300.html
> 
> The patch has already applied in commit 
> 290b6d18585c887ff2cfa30b239aa2fecfcd0308.

Seems I didn't notice that. I'll have a look.

Thanks,
Qing

> 
> Your changeset seem to be old.
> Could you test the latest qemu-xen?
> 
> Thanks,
> --
> Yuji Shimada
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>