RE: [Xen-devel] [PATCH 8/9] tmem: invocations of tmem code fromexisting xen code

[Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>]

> You use do_tmem_op() directly for 32-on-64 mode, which I 
> think is wrong
> given the definition of the interface structure (you'd 
> minimally have to use
> XEN_GUEST_HANDLE_64 in order for this to be correct). But 
> even if it was
> right (or if you make it so), it would in my opinion be a 
> requirement to
> assure it is by adding a respective entry to xen/include/xlat.lst.

I have to admit I am baffled by all aspects of XEN_GUEST_HANDLE
and just hacked on it until the code worked.  I would be grateful
for either an explanation of xen/include/xlat.lst or a pointer
to an explanation... or, even better, hints on how to fix
my code to properly use XEN_GUEST_HANDLE_64.

I would like the code to definitely support 32-on-64 and
64-on-64.  32-on-32 is optional; because of xenheap limitations
it is largely a toy, but still useful for testing.

All of this works today, but possibly only due to hackery,
which I am eager to fix properly if told how.

Thanks,
Dan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel