WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 8/9] tmem: invocations of tmem code fromexisting

To: "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 8/9] tmem: invocations of tmem code fromexisting xen code
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Fri, 06 Feb 2009 09:06:13 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 06 Feb 2009 01:05:53 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <c828f5dd-150d-4633-9995-643b3078dcc0@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <c828f5dd-150d-4633-9995-643b3078dcc0@default>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> 06.02.09 01:47 >>>
>[8] invocations of tmem code from existing xen code

You use do_tmem_op() directly for 32-on-64 mode, which I think is wrong
given the definition of the interface structure (you'd minimally have to use
XEN_GUEST_HANDLE_64 in order for this to be correct). But even if it was
right (or if you make it so), it would in my opinion be a requirement to
assure it is by adding a respective entry to xen/include/xlat.lst.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel