| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH 2 of 7] x86/pvops: add a paravirt_ident functions
|
To: |
Rusty Russell <rusty@xxxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH 2 of 7] x86/pvops: add a paravirt_ident functions to allow special patching |
|
From: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
|
Date: |
Thu, 29 Jan 2009 02:46:23 -0800 |
|
Cc: |
Zachary Amsden <zach@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Ravikiran Thirumalai <kiran@xxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx> |
|
Delivery-date: |
Thu, 29 Jan 2009 02:46:51 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<200901291835.49251.rusty@xxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<patchbomb.1233182100@xxxxxxxxxxxxxxxxx> <79ff4280c71ffeba69d2.1233182102@xxxxxxxxxxxxxxxxx> <200901291835.49251.rusty@xxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Thunderbird 2.0.0.19 (X11/20090105) |
Rusty Russell wrote:
I think I prefer:
/* make_pte etc and pgd_val etc are identity functions. */
#define paravirt_native_page_op \
(sizeof(pte_t) == sizeof(u64) ? paravirt_ident_64 : paravirt_ident_32)
Then use that everywhere rather than these defines?
Hm, also I don't think that will work because paravirt_ident_32|64
return different types. The compiler might promote paravirt_ident_32 to
returning a 64-bit number, which would be a bit disastrous.
J
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home