WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] page ref/type count overflows

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] page ref/type count overflows
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 26 Jan 2009 16:30:12 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 26 Jan 2009 08:30:28 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <497DEFB4.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acl/01xK7X4ZPdMilUKIt/SlJqkvCQ==
Thread-topic: [Xen-devel] page ref/type count overflows
User-agent: Microsoft-Entourage/12.14.0.081024
On 26/01/2009 16:15, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> I'm going to change both and do it the easy way, growing the structure from
>> 40 to 48 bytes. You can shrink it again with the tricks you describe if
>> you're keen. I'm not sure how ugly the list stuff would end up, which would
>> be my main concern, but I suppose you can hide it behind list.h-style
>> macros. I don't see there's much duplication of effort to phase the work
>> like this.
> 
> No word on the question regarding the below-4G restriction of the Xen heap?

Got rid of it. It was only needed for the pickle_domptr() thing, as you
suspected.

> Also, what's the purpose of those (_domain & 1) checks in unpickle_domptr()?

Introduced by shadow2 code, and I think it's never been needed. I'm going to
nuke it, but I will be checking some other things with the shadow code
maintainers so I'll double check that too.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel