[Xen-devel] Re: [PATCH 2/2] resume hpet at s3 resume

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 19/11/08 01:25, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> I'm not sure whether it's safe to call hpet_setup twice at boot
> phase, though it may be ok for S3 resume case. hpet_setup
> will disable/enable hpet channel, and thus 2nd call may impact
> system time a bit if hpet is taken as the clocksource (hpet
> counter is freezed when hpet is disabled)

Fixed by 18790. I introduced a global S3 counter which subsystems can use to
decide whether their hardware needs (re-)initialising. It could be generally
useful beyond fixing this HPET issue.

> Also regarding to 18786, there's inconsistency between platform
> timer name and clocksource option, such as "ACPI PM TIMER"
> and "acpi". Do you intend to use "clocksource=ACPI PM TIMER"
> as boot option? If you really want to keep such full name, then
> a speparate short name field can be introduced for comparison.

Fixed by 18789.

> Thanks,
> Kevin

 Thanks,
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel