WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 2/2] resume hpet at s3 resume

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, xen-devel组 <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 2/2] resume hpet at s3 resume
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 19 Nov 2008 12:50:06 +0000
Cc:
Delivery-date: Wed, 19 Nov 2008 04:50:34 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <0A882F4D99BBF6449D58E61AAFD7EDD601E23B2D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclJciTlq8Xy1jjRTxKqJFSpu+7uIAAI+/vNABNJAqAAGIf9jQ==
Thread-topic: [PATCH 2/2] resume hpet at s3 resume
User-agent: Microsoft-Entourage/11.4.0.080122
On 19/11/08 01:25, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> I'm not sure whether it's safe to call hpet_setup twice at boot
> phase, though it may be ok for S3 resume case. hpet_setup
> will disable/enable hpet channel, and thus 2nd call may impact
> system time a bit if hpet is taken as the clocksource (hpet
> counter is freezed when hpet is disabled)

Fixed by 18790. I introduced a global S3 counter which subsystems can use to
decide whether their hardware needs (re-)initialising. It could be generally
useful beyond fixing this HPET issue.

> Also regarding to 18786, there's inconsistency between platform
> timer name and clocksource option, such as "ACPI PM TIMER"
> and "acpi". Do you intend to use "clocksource=ACPI PM TIMER"
> as boot option? If you really want to keep such full name, then
> a speparate short name field can be introduced for comparison.

Fixed by 18789.

> Thanks,
> Kevin

 Thanks,
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>