WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [PATCH 2/2] resume hpet at s3 resume

To: 'Keir Fraser' <keir.fraser@xxxxxxxxxxxxx>, xen-devel组 <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH 2/2] resume hpet at s3 resume
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Wed, 19 Nov 2008 09:25:36 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc:
Delivery-date: Tue, 18 Nov 2008 17:26:31 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C54895F2.29258%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <0A882F4D99BBF6449D58E61AAFD7EDD601E23B29@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C54895F2.29258%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclJciTlq8Xy1jjRTxKqJFSpu+7uIAAI+/vNABNJAqA=
Thread-topic: [PATCH 2/2] resume hpet at s3 resume
>From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
>Sent: Tuesday, November 18, 2008 11:56 PM
>
>hpet_setup() is idempotent. We just need to be careful that
>hpet_broadcast_init() happens after any other caller of 
>hpet_setup(). That
>happens to be the case currently so I simplified your patch 
>considerably.
>Changeset 18787.
>

I'm not sure whether it's safe to call hpet_setup twice at boot
phase, though it may be ok for S3 resume case. hpet_setup 
will disable/enable hpet channel, and thus 2nd call may impact
system time a bit if hpet is taken as the clocksource (hpet 
counter is freezed when hpet is disabled)

Also regarding to 18786, there's inconsistency between platform
timer name and clocksource option, such as "ACPI PM TIMER"
and "acpi". Do you intend to use "clocksource=ACPI PM TIMER"
as boot option? If you really want to keep such full name, then
a speparate short name field can be introduced for comparison.

Thanks,
Kevin
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel