RE: [Xen-devel] several Qs about domain live migration

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
>Sent: Monday, November 17, 2008 3:45 PM
>
>On 17/11/08 06:50, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:
>
>> I didn't find code to check mmio holes. Then how does restore
>> side differentiate normal ram from those holes, for a hvm with
>>> 4G memory?
>
>I don't think the save side transmits entries for non-existent pages.
>

Yes, that's also my original assumption. But after reading code,
I didn't find lines to seperate those non-existence pages. I saw
one of your change (18533) to skip page patches which contain
no valid pages:
+            if ( hvm )
+            {
+                /* Look for and skip completely empty batches. */
+                for ( j = 0; j < batch; j++ )
+                    if ( (pfn_type[j] & XEN_DOMCTL_PFINFO_LTAB_MASK) !=
+                         XEN_DOMCTL_PFINFO_XTAB )
+                        break;
+                if ( j == batch )
+                {
+                    munmap(region_base, batch*PAGE_SIZE);
+                    continue; /* bail on this batch: no valid pages */
+                }
+            }
+            else

But I don't know where XEN_DOMCTL_PFINFO_XTAB may be
set for hvm domain. Could you help spot it to me?

Thanks,
Kevin
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel