| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [patch 0/6] xenblk: Add O_DIRECT and O_SYNC support.
|
To: |
Jens Axboe <jens.axboe@xxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [patch 0/6] xenblk: Add O_DIRECT and O_SYNC support. |
|
From: |
Joe Jin <joe.jin@xxxxxxxxxx> |
|
Date: |
Fri, 7 Nov 2008 08:51:47 +0800 |
|
Cc: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Xen-devel@xxxxxxxxxxxxxxxxxxx, kurt.hackel@xxxxxxxxxx, shinya.narahara@xxxxxxxxxx, Joe Jin <joe.jin@xxxxxxxxxx>, greg.marsden@xxxxxxxxxx, wen.gang.wang@xxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
|
Delivery-date: |
Thu, 06 Nov 2008 16:53:29 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20081106110759.GC21867@xxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20081106092916.GA21867@xxxxxxxxx> <C538788C.1EFF4%keir.fraser@xxxxxxxxxxxxx> <20081106110759.GC21867@xxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.4.2.2i |
On 2008-11-06 12:07, Jens Axboe wrote:
> On Thu, Nov 06 2008, Keir Fraser wrote:
> > On 6/11/08 09:29, "Jens Axboe" <jens.axboe@xxxxxxxxxx> wrote:
> >
> > >>> and be done with it.
> > >>
> > >> Yes, I can put together a patch for that easily enough, I think.
> > >
> > > Should be easy enough. Also be sure to defer any unplugging of the
> > > device until the very end, to still make a lot of room for merging and
> > > sorting.
> >
> > http://xenbits.xensource.com/staging/linux-2.6.18-xen.hg c/s 723
>
> Looks fine, but you can also get rid of the fail_put_bio and check for
> NULL return from bio_alloc(), since it'll never fail if you use
> GFP_KERNEL as the allocation mask. That's why you cannot nest
> allocations as well.
>
OK, will take a testing for this patch, thanks all.
Joe
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] |
Current Thread |
[Next in Thread> |
- Re: [Xen-devel] [patch 0/6] xenblk: Add O_DIRECT and O_SYNC support., (continued)
|
|
|
| |
|
Home