WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [patch 0/6] xenblk: Add O_DIRECT and O_SYNC support.

To: Jens Axboe <jens.axboe@xxxxxxxxxx>
Subject: Re: [Xen-devel] [patch 0/6] xenblk: Add O_DIRECT and O_SYNC support.
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 06 Nov 2008 09:26:32 +0000
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Xen-devel@xxxxxxxxxxxxxxxxxxx, kurt.hackel@xxxxxxxxxx, shinya.narahara@xxxxxxxxxx, Joe Jin <joe.jin@xxxxxxxxxx>, greg.marsden@xxxxxxxxxx, wen.gang.wang@xxxxxxxxxx
Delivery-date: Thu, 06 Nov 2008 01:27:04 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20081106085125.GZ21867@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ack/8cFU/6GWCKvkEd2QfwAWy6hiGQ==
Thread-topic: [Xen-devel] [patch 0/6] xenblk: Add O_DIRECT and O_SYNC support.
User-agent: Microsoft-Entourage/11.4.0.080122
On 6/11/08 08:51, "Jens Axboe" <jens.axboe@xxxxxxxxxx> wrote:

> I guess he needs that for waiting on them, but it really should just do:
> 
>         struct bio *bio = NULL;
> 
>         loop {
>                 if (bio) {
>                         submit_bio(bio, ...);
>                         bio = NULL;
>                 }
>                 bio = bio_alloc(...);
>                ...
>         }
> 
>         if (bio)
>                 submit_bio(bio, ...);
> 
> and be done with it.

Yes, I can put together a patch for that easily enough, I think.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel