 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] fix misc issues related to allowingsupport of mo
| To: | "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] fix misc issues related to allowingsupport of more CPUs |
| From: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
| Date: | Mon, 22 Sep 2008 08:46:33 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Mon, 22 Sep 2008 00:46:13 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C4FA7499.1D624%keir.fraser@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <48D3BEE7.76E4.0078.0@xxxxxxxxxx> <C4FA7499.1D624%keir.fraser@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 20.09.08 10:36 >>> >On 19/9/08 14:01, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > >> Includes a small improvement (I think) to last_cpu(), and a necessary >> conversion from BUG_ON() to WARN_ON() in vsnprintf(). > >Why must it be WARN_ON()? You think you could specify strings so long that >they overflow 32 bits? You've got other problems in that case. No, that's not the reason. It's because of how bitmap_scnprintf() and bitmap_scnlistprintf() work - they can (validly, assuming that the code having been derived from Linux and still being that way in Linux, hence apparently considered correct) pass negative sizes to scnprintf(), and hence it must not kill the system to actually do so. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [Xen-devel] [PATCH] x86: add hypercall to query current underlying pCPU's frequency, Tian, Kevin |
|---|---|
| Next by Date: | RE: [Xen-devel] One question on alloc_bitmap, Jiang, Yunhong |
| Previous by Thread: | Re: [Xen-devel] [PATCH] fix misc issues related to allowing support of more CPUs, Keir Fraser |
| Next by Thread: | Re: [Xen-devel] [PATCH] fix misc issues related to allowingsupport of more CPUs, Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
